Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration docs for adopting native types in 6.1 #1001

Merged

Conversation

dfreeman
Copy link
Contributor

This change removes a note about adding @glimmer/interfaces to your dependencies, as that's no longer required. It also clarifies that many tests should not need an explicit this context type set, depending on the patterns in use.

I also updated the devDependencies in this repo to align with the updated guidance.

This removes a note about adding `@glimmer/interfaces` to your
dependencies, as that's no longer required.

It also clarifies that many tests should not need an explicit
`this` context type set, depending on the patterns in use.
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAAAAAY better.

@chriskrycho chriskrycho merged commit 5f14aa8 into emberjs:master Dec 21, 2022
@dfreeman dfreeman deleted the update-migration-notes-for-native-types branch December 21, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants