Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle async behaviour outside of tests #253

Merged

Conversation

mydea
Copy link
Contributor

@mydea mydea commented Feb 28, 2017

This fixes ember-engines/ember-engines#341. Not 100% sure if that might have any negative side effects, but it fixed it for me.

@trentmwillis
Copy link
Member

trentmwillis commented Mar 3, 2017

One thing I worry about with this is that if you have async behavior before starting your tests, then this approach does not prevent tests from starting to run. I think that this is actually a good thing (less magic), but it is also different from previous behavior.

@rwjblue would appreciate your thoughts here. Note: I think this ties in with the ideas presented in ember-cli/ember-cli-qunit#171, as you could then have control over doing async things and determining when tests are actually loaded.

@trentmwillis
Copy link
Member

Sorry for letting this sit so long. After reviewing again, I think my concerns noted above are not really valid.

@mydea would you mind rebasing this? If CI is still green, then I'll go ahead and merge. Thanks!

@mydea mydea force-pushed the fix-async-behaviour-outside-tests branch from 96d034e to c9eb369 Compare April 11, 2017 07:08
@mydea
Copy link
Contributor Author

mydea commented Apr 11, 2017

Done, I rebased on master, seems to still be fine!

@trentmwillis trentmwillis merged commit ed04392 into emberjs:master Apr 11, 2017
@trentmwillis
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests in lazyLoading engine doesn't work
2 participants