Fix usage within applications that do not have ember-auto-import. #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the `ember-qunit` files are analyzed by `ember-auto-import`. `ember-auto-import` requires that the host runs through the registry (because that is where the analysis actually happens). Without this change (e.g. in `ember-qunit@5.0.0-beta.3`) applications that do **not** have `ember-auto-import` as dependencies themselves _or_ do not have a direct import of `qunit` somewhere in their own code would simply never have `QUnit` defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change (e.g. in
ember-qunit@5.0.0-beta.3) applications that do not haveember-auto-importas dependencies themselves or do not have a direct import ofqunitsomewhere in their own code would simply never haveQUnitdefined.