Relax peer dependency minimums to ember-qunit@5.0.0 versions #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…versions. ember-qunit@5.0.0 shipped with `qunit: ^2.13.0` and `@ember/test-helpers: ^2.1.0`. However, when Dependabot landed a dependency update for our internal dev dependencies it also increased the minimum for the peerDep (in 719af61 and fd9fa19) both of which were released in ember-qunit@5.1.2. Changing the minimum version of a peer dependency that we enforce (via `validatePeerDependencies`) should be considered a breaking change! This reverts that change and sets the peer dependencies back to its value when 5.0.0 was published.
rwjblue
force-pushed
the
relax-peer-dependency
branch
from
1a016f4 to
58e85fc
Compare
rwjblue
changed the title
scalvert
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-qunit@5.0.0 shipped with
qunit: ^2.13.0and@ember/test-helpers: ^2.1.0. However, when Dependabot landed a dependency update for our internal dev dependencies it also increased the minimum for the peerDep (in 719af61 and fd9fa19) both of which were released in ember-qunit@5.1.2.Changing the minimum version of a peer dependency that we enforce (via
validatePeerDependencies) should be considered a breaking change!This reverts that change and sets the peer dependencies back to its value when 5.0.0 was published.