-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dependency on klassy, prefer raw JS or core-object #56
Comments
Why? |
why not? |
It's another dep, that does the same thing as other stuff we already have. Seems strange to add yet another object model. Ultimately, if it was published to NPM it would be more reasonable. |
Because we have something that works here, and a bunch of other things that are actually broken we could put our times into... |
One of the reasons I wrote klassy.js was to have an object model in which classes could take constructor arguments. This capability is used to good effect in ember-test-helpers. I'd be glad to publish to npm. Do either of you publish ES6-module-only libs to npm (i.e. without transpiled builds)? Looking for some conventions to follow... |
Alright - I've published klassy to npm: https://www.npmjs.com/package/klassy This is something I've meant to do anyway, so thanks for the push. Sooo... |
the goal is 100% NPM installs to enable the cut over from bower. cc @chadhietala |
by June 12? |
@dgeb Negative. |
by asap :P |
Since klassy is no longer a blocker here, I'm closing in favor of #58. |
cc @dgeb
The text was updated successfully, but these errors were encountered: