Adding routes at runtime no longer works

[yosoyju]

Issue #2892 allowed new routes to be added at runtime. This appears to no longer function in 1.11.3 or 1.12.0 beta 1.

[rwjblue]

Can you provide a reproduction? The tests added in that pull request are all passing, so I'm not sure how this is failing without a repro.

[yosoyju]

Here is a JSBin running in Ember 1.10.0. Wait two seconds, then click the Foo link. The Bar link is there.

http://emberjs.jsbin.com/cogofekuho/2/

Here is the same JSBin running 1.11.3. Clicking the link never shows the Bar link because the route is seemingly never registered.

http://emberjs.jsbin.com/kilevi/1/

[honbo]

Seeing this as well after upgrading to Ember 1.11. Router.map can still be called multiple times, but the actual router instance isn't being remapped when that happens. The tests in the aforementioned commit aren't failing because the second call to Router.map is still happening before app initialization (which IMO doesn't reflect the spirit of the enhancement--in practice the second call to Router.map would happen after initialization).

As a temporary workaround I have resorted to mimicking some of the behavior of _initRouterJs after calling Router.map to at least have my new routes recognized:

r = App.registry.lookup('router:main')
cb = r.constructor.dslCallbacks
dsl = new Ember.RouterDSL null,
    enableLoadingSubstates: false
generateDSL = ->
    @resource 'application', { path: "/", overrideNameAssertion: true }, ->
        b.call @ for b in cb
generateDSL.call dsl
r.router.map dsl.generate()

[rwjblue]

To be honest, I was not aware that we supported lazily defining routes (after app initialization). I'll try to confirm with the rest of the core team, and see if it was intended as a public API.

[yosoyju]

Is there any update to this?

[rwjblue]

At this point, I would say that dynamically adding more routes after router initialization is not supported.

Sorry for keeping this issue open so long...

[sdhull]

Hah I just posted in discuss.emberjs.com about this ... I guess (for now) I'll try @honbo's hack above and see if that works still (hopefully still works 2 yrs later 😬 )

[sdhull]

uhhh trying to reproduce your success @honbo ... in your snippet, it's adding the 'application' route right?

[sdhull]

Ohhhh you run that snippet after calling Router.map again at runtime, right?

[sdhull]

OK got some deprecation warnings but it works! 🎉
Thanks @honbo ❤️