Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documention Clarification #11020

Closed
atomkirk opened this issue May 4, 2015 · 2 comments
Closed

Documention Clarification #11020

atomkirk opened this issue May 4, 2015 · 2 comments

Comments

@atomkirk
Copy link

atomkirk commented May 4, 2015

Here:

http://guides.emberjs.com/v1.11.0/understanding-ember/dependency-injection-and-service-lookup/

it says "Ember's container should be viewed as an implementation detail, and is not part of the supported public API." But I see this.container.lookup being used and suggested as a solution all over these issues and forums. If container is being provided as a property on main framework objects, isn't that contradictory?

Also, if I'm assuming using the container to lookup things is ok as long as it's accessed this way, I can't find any public API docs about accessing the container property on a controller, route, etc.

So, is this.container.lookup(…) discouraged or ok? And if so, why? And if so, where is the docs for the container property on framework classes?

@stefanpenner
Copy link
Member

If container is being provided as a property on main framework objects, isn't that contradictory?

It exists as a escape valve for use-cases not initially understood, but assumed to exist. Hence being discouraged. There is some work by @dgeb that should further remove more of the discovered use-cases.

@rwjblue
Copy link
Member

rwjblue commented May 8, 2015

Please take a look at emberjs/rfcs#46, and chime in with your thoughts.

I'm going to close this, as I believe that RFC directly addresses the concern.

@rwjblue rwjblue closed this as completed May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants