Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong view and hook in deprecation of render revalidation during render #11505

Closed
krisselden opened this issue Jun 18, 2015 · 4 comments
Closed
Labels

Comments

@krisselden
Copy link
Contributor

If you change state during render, the deprecation message output tells you the wrong view that triggered it and has the hook hard coded to didInsertElement.

http://emberjs.jsbin.com/boyoxihija/1/edit?html,js,console,output

@krisselden krisselden added the Bug label Jun 18, 2015
@eccegordo
Copy link
Contributor

Confirm this deprecation behavior caused me confusion as I was trying to fix deprecation notices during 1.13 upgrade.

Adding deprecation notice in case people are searching

DEPRECATION: A property of Ember.OutletView:ember265 was modified inside the didInsertElement hook. You should never change properties on components, services or models during didInsertElement because it causes significant performance degradation.

@rwjblue
Copy link
Member

rwjblue commented Apr 18, 2016

#13353 addresses this

@kellyselden
Copy link
Member

This should be closed?

@locks
Copy link
Contributor

locks commented Dec 15, 2016

I'm trusting @kellyselden on the call ;P

@locks locks closed this as completed Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants