The classNameBindings property for the {{link-to}} helper doesn't update in 1.13.x

[courthead]

In Ember 1.12 you could do {{#link-to "path" classNameBindings="model.property:some-class"}}..., and when model.property changed the link's class would change accordingly. I'm finding that in Ember 1.13 the class is set initially, but doesn't update dynamically as model.property changes.

Here's a JSBin: http://emberjs.jsbin.com/duvocorodo/edit?html,css,js,output

[btecu]

Can confirm the same issue.

[mixonic]

This seems like a regression. Confirmed on 1.13.3.

[mutewinter]

Confirmed, keeping us from migrating to 1.13.

[stefanpenner]

if someone has time to submit a PR with a failing test, that would help get the ball moving.

[aortbals]

I've submitted a failing test. I'm not entirely sure yet where in the stack the fix needs to be made. I'm looking into it. I'm happy to update the PR with the fix If I get to it before someone else. Any guidance on where this regression might have been introduced is also appreciated.

[raytiley]

Not sure if its helpful but this also fails using the newer inline if syntax, which I imagine just uses attributeBindings under the hood?

I tried debugging this but got lost pretty quickly. In the ComponentNodeManager I see the attrs are correct but once block is called somewhere down the line the joinClasses helper gets called and the array of classes it gets has the old data. So all the changes / rerendering is happening, just somewhere down the line the updated attrs isn't getting passed along correctly.

[aortbals]

Another few pieces of information:

After additional debugging, I wanted to confirm that this does seem to be specific to LinkComponent. When a link-to is rerendered with class bindings like the following, it does not update:

{{#link-to 'home' classNameBindings='isHomeHighlighted:is-highlighted'}}Home{{/link-to}}

And as @raytiley mentions, an inline if subexpression also does not work. Side note: I'm not sure which is correct here, class or classNames, both render once and do not rerender correctly like the previous example:

{{#link-to 'home' classNames=(if isHomeHighlighted 'is-highlighted')}}Home{{/link-to}}

{{#link-to 'home' class=(if isHomeHighlighted 'is-highlighted')}}Home{{/link-to}}

However, the following cases do rerender correctly:

Binding on a normal <a> tag

<a href='http://foo.bar' class={{if isHomeHighlighted 'is-highlighted'}}>Foo Bar</a>

A standard generated blank component with classNameBindings

{{#test-class-bindings classNameBindings='isHomeHighlighted:is-highlighted'}}Home{{/test-class-bindings}}

[rwjblue]

Nice summary of issues by @aortbals in #11391 (comment):

This doesn't appear to affect other components, only the LinkView component. See #11763. This seems to affect all bound attributes on link-to.

Issues: class #11390, #11763, tabindex #11763