Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

RFC #0236 - Tracking for Ember.String deprecation #26

Closed
11 of 17 tasks
kategengler opened this issue Feb 12, 2019 · 1 comment
Closed
11 of 17 tasks

RFC #0236 - Tracking for Ember.String deprecation #26

kategengler opened this issue Feb 12, 2019 · 1 comment
Assignees
Labels
needs planning:ember.js Needs planning by ember.js team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember-data Needs planning by ember-data team team:ember.js ember.js team

Comments

@kategengler
Copy link
Member

kategengler commented Feb 12, 2019

RFC #0236 - Tracking for Ember.String deprecation

Champion: @locks


Expand for Instructions

All teams need to consider a merged RFC to plan any required work. Each team should comment on or edit this with links to issues for the work (or a note to the effect of "No work required").

See the README for more information
See #3 for an example

Under each team, for each repo requiring work for the RFC under that team:
### [repo name](repo url)

- [ ] (issue or pr) description, (issue or pr) link

Remove Repos that do not apply, conversely, there will probably be other repos that need work and should be added.

Misc

  • investigate if we should build a codemod for moving people off of the Ember.String prototype extension

Ember.js Team

  • ember.js
  • @ember/string
    • extract addon
    • publish to npm
    • deprecate loc
    • Don't include duplicated code (?)
    • publish 2.0 without loc (PR)

Ember CLI Team

Ember Data Team

  • ember-data
    • add @ember/string as a dependency [PR]
    • potentially remove usages of @ember/string?

Learning Team

  • deprecation-app
    • add entry for loc deprecation (PR)
    • add entry for prototype extension deprecation (PR)
    • add entry for Ember.String deprecation (deprecates importing from @ember/string without the addon installed)

Steering Committee

No work required.

@kategengler kategengler added the team:ember.js ember.js team label Feb 22, 2019
@rwjblue rwjblue added needs planning:learning Needs planning by the learning team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember-data Needs planning by ember-data team needs planning:ember.js Needs planning by ember.js team needs planning:steering committee Needs planning by the steering committee and removed needs planning:learning Needs planning by the learning team labels Apr 30, 2019
@MelSumner MelSumner removed the needs planning:learning Needs planning by the learning team label May 6, 2019
@kategengler kategengler removed needs planning:steering committee Needs planning by the steering committee labels May 22, 2019
@jamescdavis
Copy link

FYI: Effective as of Ember 3.25, importing isHtmlSafe and htmlSafe from @ember/string has now been formally deprecated in the code (emberjs/ember.js#19339) and in the deprecation app (ember-learn/deprecation-app#758).

@locks locks closed this as completed May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs planning:ember.js Needs planning by ember.js team needs planning:ember-cli Needs planning by ember-cli team needs planning:ember-data Needs planning by ember-data team team:ember.js ember.js team
Projects
None yet
Development

No branches or pull requests

5 participants