Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Search doesn't work #3296

Open
lulezi opened this issue Apr 18, 2018 · 6 comments
Open

Search doesn't work #3296

lulezi opened this issue Apr 18, 2018 · 6 comments

Comments

@lulezi
Copy link
Contributor

lulezi commented Apr 18, 2018

Hi there

The search on https://guides.emberjs.com/v3.0.0/ seems to be broken. After clicking on a search result, the correct page loads, but then redirects to an unfound one.

2018-04-14 10_58_13

@toddjordan
Copy link
Contributor

Thanks for reporting. Our algolia crawler configuration is woefully out of date: https://github.com/algolia/docsearch-configs/blob/master/configs/emberjs_versions_new.json

The urls are hard-coded for version 2.13 and there is an extra "type" query param being added to the url. We'd at least need to get the version updated to "release" (https://emberjs.com/api/ember/release) and use the new url scheme we've been using for post 2.16 releases.

@toddjordan
Copy link
Contributor

FYI the search on the actual api https://emberjs.com/api/ember/release site uses a different approach and is not affected by this issue. You should search api documentation with that.

@toddjordan
Copy link
Contributor

Update: @sivakumar-kailasam is working with the algolia team to debug the issue.

@sivakumar-kailasam
Copy link
Member

Update: The API search is functional but guides search setup is still in the works

@patocallaghan
Copy link
Contributor

@sivakumar-kailasam was coming to open an issue with search but just wondering if it's the same one?

If I search for something from the API docs in the homepage search input, e.g. Service, and click a result it brings me to the 3.1 docs, e.g. https://guides.emberjs.com/v3.1.0/applications/services/#ember315515

@sivakumar-kailasam
Copy link
Member

Oh. That's an isolated issue. Please open a separate issue and we'll track it down

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants