Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon-dev@v5] Cannot call "addWatchFile" after the build has finished. #2081

Closed
simonihmig opened this issue Aug 28, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@simonihmig
Copy link
Collaborator

Running into this error on a large repo building a ton of v2 addons. It is not happening everywhere, rather rarely, so maybe some kind of race condition?

Stack trace (anonymized):

(plugin copy-assets) RollupError: Cannot call "addWatchFile" after the build has finished.
at error (/xxx/somepackage/node_modules/rollup/dist/shared/rollup.js:353:30)
at Object.error (/xxx/somepackage/node_modules/rollup/dist/shared/rollup.js:1721:20)
at Object.addWatchFile (/xxx/somepackage/node_modules/rollup/dist/shared/rollup.js:1713:29)
at Object.generateBundle (/xxx/node_modules/@embroider/addon-dev/src/rollup-keep-assets.ts:41:14)
at /xxx/somepackage/node_modules/rollup/dist/shared/rollup.js:1914:40

Likely related to #2007 /cc @vstefanovic97

@simonihmig simonihmig added the bug Something isn't working label Aug 28, 2024
@embroider-build embroider-build deleted a comment Aug 28, 2024
@simonihmig
Copy link
Collaborator Author

Nvm, this was due to being on an older rollup version. Missed the discussion here, and the new peer dependency. (we have so many peer dependency issues 😅 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant