Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbind from Rails #108

Closed
inossidabile opened this issue Aug 8, 2013 · 9 comments
Closed

Unbind from Rails #108

inossidabile opened this issue Aug 8, 2013 · 9 comments

Comments

@inossidabile
Copy link

Am I getting it wrong, @thedeeno, or 4 months ago you removed every possible way of integration with raw Sprockets::Environment? Are there are any reasons for that?

@thedeeno
Copy link
Collaborator

thedeeno commented Aug 8, 2013

Hmm, I didn't explicitly intend to prevent direct integration. What's your use case?

@inossidabile
Copy link
Author

I have instance of Sprockets. Now I need to add path to hamlcoffee vendored asset. But I have no way to do that since you removed the method that was returning the path to the gem's vendor directory location.

@thedeeno
Copy link
Collaborator

thedeeno commented Aug 8, 2013

Can you explain more about the need to work at this raw level? Is there something preventing you from just including hamlcoffee via a require directive in one of your assets? The gem's asset should already be in the load path.

//= require hamlcoffee

@inossidabile
Copy link
Author

Can you link the line that adds it to the load path? Cause it's not and as far as I see from sources it should not.

@thedeeno
Copy link
Collaborator

thedeeno commented Aug 8, 2013

Are you using this outside of rails? This is a rails engine, so rails will include this gem's vendor/assets/javascripts/ in the load path. There's not need to explicitly require it in Rails.

@inossidabile
Copy link
Author

This is exactly what I'm talking about. I'm using it with raw sprockets. No Rails. By removing that assets_path helper you automatically dropped support for Sinatra, Jekyll and all custom builders. Resurrect it please.

@inossidabile
Copy link
Author

Here's something that should ensure you are getting me right: https://github.com/netzpirat/haml-coffee-sinatra/blob/master/app.rb#L13

@netzpirat
Copy link
Collaborator

Thanks @inossidabile for bringing this up. I've reverted the commit in question and released version 1.13.1 that contains the helper API again. Sorry for any inconvenience, I should have known why I've added this :)

@inossidabile
Copy link
Author

🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants