-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trunk
template alongside current template for web
#44
Comments
trunk
instead of bash scripts for webtrunk
template alongside current template for web
That sounds like a good idea! Would you like to contribute it? |
Sure! I can go with the branch approach and link that in the |
I think a separate folder is better first step (easier to keep up-to-date). If it works well, we can maybe switch it to be the default :) |
so, i tried doing this https://github.com/coderedart/eframe_template . it was pretty easy to do. most of the work is in https://github.com/coderedart/eframe_template/commit/b25fc179130da765e6cdee8f2bc29bd219e33373 commit. just needed to add the copy commands, comment out the custom wasm_bindgen stuff from index.html, add the start function to main.rs and finally set the favicon (in another commit). I added a separate pages.yml to automate the publishing to github pages part.
anyway, i accidentally clicked |
forgot to mention that trunk uses EDIT: even if the workflow runs, you must also go to github repo -> settings -> pages -> source -> set to branch : gh-pages + /(root) as source and click on save. only after that will pages-build-deployment action will run (everytime there's a push to gh-pages by our pages.yaml workflow) and deploy the latest files to servers. |
trunk
(https://trunkrs.dev/) is a complete build driver for wasm / web. It is very easy to use and has good defaults, and can easily be configured. I believe instead of using bash scripts and whatnot, it would be better to usetrunk
so that it's simpler to deploy and work with.My suggestion would be to keep the scripts, but add a separate branch (or folder?) showing how it looks with
trunk
. Essentially it's just a simpleindex.html
file at the root of the repository (whichtrunk
uses to configure the build with), as seen like here.The text was updated successfully, but these errors were encountered: