-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider enabling dark-light by default in eframe #2388
Comments
I have gone back and forth on this quite a bit: #1941 |
Fair enough. And, contrary to what I said above, an application ignoring the system theme isn't as severe a problem as being inaccessible with a screen reader, since the user can use an external tool to invert the colors. But let no one accuse me of ignoring accessibility needs other than screen readers. |
That said, of the 3 reasons mentioned in that PR, the only one that is persuasive to me is the one about difficulties on Linux. Where can I read more about this? I wonder if the same issues will come up when AccessKit introduces support for AT-SPI, via zbus. On the other two reasons, while it's ultimately your call, I think that adapting to the users' needs and preferences, on the assumption that we don't know who our ultimate users are, should take priority over conforming to developers' expectation of a fixed appearance under their control. That is, while the latter should be an option, it should require more work for the developers that want it, just like disabling AccessKit in eframe. |
I can't find the build issue right now, but dark-light has a few problems: |
OK, I'll close this one for now, since the latency issue means that dark-light isn't ready for wide deployment by default. |
Rationale: For some visually impaired users, using a dark or light color scheme is an accessibility feature, as important as a screen reader is for a totally blind user.
The text was updated successfully, but these errors were encountered: