Position persistence and sane clamping to still-available monitors for Windows #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… restored between sessions.
# Conflicts: # crates/egui-winit/CHANGELOG.md
emilk
requested changes
Jan 23, 2023
That's a good point, I have not. I'll give it a look soon. |
I have tested this on a display with resolution scaling applied. I had already done that, but was second guessing that I had done it properly. |
Discovered an issue where putting the monitor off a non-primary monitor to the left causes the position to be off the monitor x and y range, clamping to the primary instead of the non-primary.
…any part of the window had been visible on a remaining monitor.
Rather than just wrap in blocks, I kind of prefer the more explicit if cfg! call for line 114. CHANGELOG.md - correct a missing paren I noticed
emilk
reviewed
Jan 25, 2023
emilk suggested changelog formatting Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
emilk
approved these changes
Jan 26, 2023
Nykseli
added a commit
to Nykseli/egui
that referenced
this pull request
Feb 1, 2023
* Patch is a modified version of emilk#2583
Satisfy CI Error
emilk
reviewed
Feb 4, 2023
lictex
pushed a commit
to lictex/egui
that referenced
this pull request
Feb 5, 2023
…r Windows (emilk#2583) * Attempt to fix monitor clamping on Windows so window positions can be restored between sessions. * Missed a change. * Renamed variables, reorganized some lines of code, and added some more comments. * Cargo fmt run * Updated CHANGELOG.md to briefly describe my change * Updated CHANGELOG.md to briefly describe my change * Applied suggested fixes from emilk Discovered an issue where putting the monitor off a non-primary monitor to the left causes the position to be off the monitor x and y range, clamping to the primary instead of the non-primary. * Fix for matching negative restored window positions. Should clamp if any part of the window had been visible on a remaining monitor. * Apparently compiler attributes on statements have been marked unstable. Rather than just wrap in blocks, I kind of prefer the more explicit if cfg! call for line 114. CHANGELOG.md - correct a missing paren I noticed * I was being silly, I don't need to clone inner_size_points on line 112 * Cargo fmt run * Update crates/egui-winit/CHANGELOG.md emilk suggested changelog formatting Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com> * Update window_settings.rs Satisfy CI Error * clippy --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1469.
Doesn't know where the task bar is, and that doesn't seem to be available in winit, so clamping vertically may result in some of the window being behind it.