Demo keyboard input "p" not working

[jiricodes]

Short Description

In the deployed egui demo the character p is being ignored in some TextEdit fields.

Expected behaviour

Press P on keyboard and a p character appears in selected editable field.
Press Shift + P on keyboard and a P character appears in selected editable field.

Observed behaviour

The keyboard input P is ignored in following fields:

• Demos
  • Code Editor
  • Code Example
  • Font Book
  • Misc Demos - password
    • [ Desktop ] works as expected until visibility is toggled on or off
      • gets fixed by selecting all the text and deleting it
      • one by one character deletion doesn't fix
  • TextEdit
    • [ Desktop ] - buttons start and end seems to fix things, making the 'P' key being registered as expected. Until the cursor is moved manually. (maybe a hint towards the root cause?)
  • Window Options
• EasyMark

These fields work as expected:

• HTTP

Note of inconsistency - when testing, spamming key p while changing TextEdit field selection resulted in registering the character occasionally in either of the fields (sometimes in the just selected and sometime in the just deselected)

Native build of egui_demo_app (master branch) locally works fine.

Tested Platforms

• Desktop: Ubuntu 22.04.1 LTS
  • Chrome (Version 110.0.5481.77 (Official Build) (64-bit))
  • Firefox (109.0.1 (64-bit))ppp
• Mobile: iOS 16.2
  • Safari
  • Chrome

[YgorSouza]

Apparently the reason is this:

egui/crates/eframe/src/web/events.rs

Lines 92 to 97 in 38849fe

	let prevent_default = if egui_key == Some(Key::Tab) {
	// Always prevent moving cursor to url bar.
	// egui wants to use tab to move to the next text field.
	true
	} else if egui_key == Some(Key::P) {
	true // Prevent ctrl-P opening the print dialog. Users may want to use it for a command palette.

This code should probably check for modifiers. For Windows and Linux it's Ctrl, and for macOS I guess it's Command? But I am not sure.

[emilk]

Oh wow, this is embarrassing 🤦

Yes, should be a very easy fix to check for modifers when we ignore keys.

[emilk]

eframe 0.21.3 released with fix