Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Button has transparent background until hovered #384

Closed
brayden-wong opened this issue Mar 25, 2024 · 4 comments
Closed

Close Button has transparent background until hovered #384

brayden-wong opened this issue Mar 25, 2024 · 4 comments

Comments

@brayden-wong
Copy link

brayden-wong commented Mar 25, 2024

Describe the feature / bug 📝:

When creating any type of toast message, the close button background color appears transparent until I hover over it. Note this only started happening on version 1.4.41

A temporary fix is to do the following
toast.info("Notification received", { classNames: { closeButton: "bg-white" }, }); // using tailwind

Steps to reproduce the bug 🔁:

  1. install version version 1.4.41
CleanShot.2024-03-25.at.08.47.03.mp4
@Omkar-omi
Copy link

Insted of in-lining tailwind classes on every toast you can add closeButton: "group-[.toast]:bg-white" in the
toastOptions,this way every toast will have the same style's.

<Sonner
  duration={5000}
  theme={"dark"}
  className="toaster group"
  toastOptions={{
    classNames: {
      toast:
        "group toast group-[.toaster]:bg-background group-[.toaster]:text-foreground group-[.toaster]:border-border group-[.toaster]:shadow-lg",
      description: "group-[.toast]:text-muted-foreground",
      actionButton:
        "group-[.toast]:bg-primary group-[.toast]:text-primary-foreground",
     cancelButton:
        "group-[.toast]:bg-muted group-[.toast]:text-muted-foreground",   
+    closeButton: "group-[.toast]:bg-white",
    },
  }}
  {...props}
/>

@powdaze
Copy link

powdaze commented May 30, 2024

The issue arises due to the changes to styling made in #377 .

The button now gets styled with this portion of Tailwind's preflight css:

/*
1. Correct the inability to style clickable types in iOS and Safari.
2. Remove default button styles.
*/

button,
input:where([type='button']),
input:where([type='reset']),
input:where([type='submit']) {
  -webkit-appearance: button; /* 1 */
  background-color: transparent; /* 2 */
  background-image: none; /* 2 */
}

Not exactly sure the proper fix, but the workaround mentioned above works for now.

@mfts
Copy link

mfts commented Aug 27, 2024

Thanks @Omkar-omi for your hint.

Since many are using shadcn-ui for the sonner implementation: here's my fix that also restores the hover effect

<Sonner
    theme={theme as ToasterProps["theme"]}
    className="toaster group"
    toastOptions={{
      classNames: {
        toast:
            "group toast group-[.toaster]:bg-background group-[.toaster]:text-foreground group-[.toaster]:border-border group-[.toaster]:shadow-lg",
          description: "group-[.toast]:text-muted-foreground",
          actionButton:
            "group-[.toast]:bg-primary group-[.toast]:text-primary-foreground",
          cancelButton:
            "group-[.toast]:bg-muted group-[.toast]:text-muted-foreground",
+        closeButton:
+         "group-[.toast]:bg-background group-[.toast]:border-border group-[.toast]:text-foreground group-[.toast]:hover:bg-muted ",
        },
      }}
      {...props}
    />

@emilkowalski
Copy link
Owner

Fixed in #504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants