Drawer Navigation Issue: Scrolling to Top on Back Navigation with React Router

[shkumbinhasani]

We are facing an issue while integrating Vault with a route-specific opening. Our setup includes tabs within a drawer component. The problem arises when a user interacts with these tabs and then navigates back, leading to an unintended scroll to the top of the page. Below are the key observations and steps we've tried:

• The issue does not occur with a standard modal implementation.
• The issue is not present when using the Radix Modal.
• The problem does not manifest during the first use.
• The issue consistently occurs after the drawer has been opened and a page navigation action follows.

Any insights or solutions to address this problem would be greatly appreciated. 😃

Sandbox: https://codesandbox.io/p/sandbox/gracious-golick-jcrczn
Video:

Screen.Recording.2024-01-11.at.4.10.26.PM.mov

[shkumbinhasani]

I found out this is being caused by this part here

vaul/src/use-position-fixed.ts

Line 67 in f17c93f

if (activeUrl !== window.location.href) {

I see that this functionality is meant to be like this, In our use-case after x time of scrolling loosing track can be quite a bad UX, that why I introduced preventScrollRestoration that defaults to true to not break anything.

#202

[emilkowalski]

Fixed in #202