Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in drawer can't be selected #346

Closed
dmytro-ulianov opened this issue May 7, 2024 · 10 comments
Closed

Text in drawer can't be selected #346

dmytro-ulianov opened this issue May 7, 2024 · 10 comments

Comments

@dmytro-ulianov
Copy link

There was already a similar issue before: #295.

It looks like the #182 (drawer handle component) discards the changes introduced in #314 (block swipe if in wrong direction).

My guess is that this change from #314 was reverted in drawer handle PR and that's the reason why text selection is not working
image

@shrihari-prakash
Copy link

@dmytro-ulianov did you ever find a solution?

@fruityfishy
Copy link

fruityfishy commented May 26, 2024

@shrihari-prakash, following worked for me:

<Drawer.Content className="select-text">
                This is your drawer content
</Drawer.Content>

Basically overriding the user-select with user-select: text;
PS: I am using tailwind user-select but you should be able to use user-select: text; for the drawer content's style.

@shrihari-prakash
Copy link

@fruityfishy , unfortunately, this also does not seem to work for me :(. Does this solution work for you on mobile phones?

@fruityfishy
Copy link

@shrihari-prakash, ah that's unfortunate. I haven't checked on mobile but I can confirm it works on web.

@shrihari-prakash
Copy link

Hello @emilkowalski , would there be any plan to fix this? Or would you possibly know any workarounds that we could try to solve this issue? Would appreciate any clue on how to resolve this.

@dmytro-ulianov
Copy link
Author

@shrihari-prakash, i plan to investigate this issue within the next week or two to determine how it can be resolved.
and i believe the changes proposed in #314 should meet our needs.

@zzh8829
Copy link

zzh8829 commented Aug 6, 2024

@fruityfishy , unfortunately, this also does not seem to work for me :(. Does this solution work for you on mobile phones?

you can fix it with !select-text in tailwind or !important with regular css

@emilkowalski
Copy link
Owner

emilkowalski commented Sep 13, 2024

Fixed in #408

@dmytro-ulianov
Copy link
Author

@emilkowalski do you think it makes sense to reopen this issue since it hasn't been really resolved?

here's the discussion on twitter

@wong2
Copy link

wong2 commented Oct 8, 2024

Still facing this with 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants