Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation Tabs disappeared #172

Closed
norhan-elnezamy opened this issue Feb 16, 2022 · 14 comments · Fixed by #173
Closed

Relation Tabs disappeared #172

norhan-elnezamy opened this issue Feb 16, 2022 · 14 comments · Fixed by #173

Comments

@norhan-elnezamy
Copy link

I 'm using the relation tabs and it was working fine. but suddenly it stoped without any change in code from my side, I expected it's related to the last released version so, I had to downgrade to version 1.4.6 and then it works fine again .

@RVxLab
Copy link
Collaborator

RVxLab commented Feb 16, 2022

Sounds like an issue I found while doing production builds in #157, can you confirm?

@norhan-elnezamy
Copy link
Author

norhan-elnezamy commented Feb 16, 2022

yes, it seems like it. No tabs appear in details page.
resource
details-page

@RVxLab
Copy link
Collaborator

RVxLab commented Feb 16, 2022

Strange. I’ll need to research this. Perhaps update the build settings.

@norhan-elnezamy norhan-elnezamy changed the title Relation Panel disappeared Relation Tabs disappeared Feb 16, 2022
@RVxLab
Copy link
Collaborator

RVxLab commented Feb 17, 2022

I'm currently unable to reproduce this locally with a fresh production build.

But to hopefully fix this issue can you please do the following:

  1. Re-publish your Nova assets with php artisan nova:publish
  2. Update the nova-tabs package to dev-improved-frontend-building
"require": {
    "eminiarts/nova-tabs": "dev-improved-frontend-building"
},
"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/eminiarts/nova-tabs"
    }
],

Then run composer update eminiarts/nova-tabs.

@elizdlt202
Copy link

Hi, I think I'm having the same issue. The whole content within Tabs::() has disappeared. the screenshot shows what I've been using - and everywhere I'm using it - it does not display at all in the ui. This only happened after the recent version update

Screen Shot 2022-02-22 at 10 02 56 AM

@RVxLab
Copy link
Collaborator

RVxLab commented Feb 22, 2022

Hi, I think I'm having the same issue. The whole content within Tabs::() has disappeared. the screenshot shows what I've been using - and everywhere I'm using it - it does not display at all in the ui. This only happened after the recent version update

Screen Shot 2022-02-22 at 10 02 56 AM

Can you take the instructions from my previous comment and see if that fixes it?

@elizdlt202
Copy link

Hi, your previous comment ( solution ) actually didnt work for me.

@norhan-elnezamy
Copy link
Author

I'm currently unable to reproduce this locally with a fresh production build.

But to hopefully fix this issue can you please do the following:

  1. Re-publish your Nova assets with php artisan nova:publish
  2. Update the nova-tabs package to dev-improved-frontend-building
"require": {
    "eminiarts/nova-tabs": "dev-improved-frontend-building"
},
"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/eminiarts/nova-tabs"
    }
],

Then run composer update eminiarts/nova-tabs.

the solution works fine with me, thanks a lot for supporting.

@BertKooij
Copy link

I had the same issue and tried your instructions, sadly it did not seem to fix the issue. But it seems to be related to something that has been changed in Laravel Nova. I was running v3.28.2 and just updated it to the latest version (v3.31.0) which did the trick. The tabs are now being displayed again with version 1.5.0.

@RVxLab
Copy link
Collaborator

RVxLab commented Feb 23, 2022

@norhan-elnezamy @BertKooij Thanks for verifying this with me! I’ll release 1.5.1 today with the new dist files.

@elizdlt202 If you’re running an older version of Nova, please update to the latest.

@RVxLab
Copy link
Collaborator

RVxLab commented Feb 23, 2022

Version 1.5.1 has been released to address this issue. An update to Nova may be required to fully fix this, unfortunately there's not much I can do about that.

@elizdlt202
Copy link

Thank you @RVxLab for your quick care on this! Much appreciated!
I'll try to see if it works again.

@mziraki
Copy link

mziraki commented Mar 7, 2022

@RVxLab
same issue here, even with Nova v3.31.0 and this package v1.5.1!
I tried all the solutions in previous comments!
it's okay with v1.4.6!

@RVxLab
Copy link
Collaborator

RVxLab commented Mar 7, 2022

Outside of publishing the assets on the latest Nova build I really don't know what else could fix this.

Otherwise please provide a private repository with a minimal example as this is a ridiculously hard issue to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants