Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Ambassador CRDs uses underscores that fail validation #1562

Closed
suever opened this issue May 22, 2019 · 3 comments
Closed
Labels
stale Issue is stale and will be closed

Comments

@suever
Copy link
Contributor

suever commented May 22, 2019

Describe the bug
When attempting to use the Mapping CRD to associate a Service with ambassador using a metadata.name value with an underscore such as qotm_mapping (as shown in the documentation), validation fails because only lower-case alpha-numeric values, - or . are allowed in the name.

The exact error message is:

The Mapping "qotm_mapping" is invalid: metadata.name: Invalid value: "qotm_mapping": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is 'a-z0-9?(.a-z0-9?)*')

To Reproduce
Steps to reproduce the behavior:

  1. Create a Mapping resource using the configuration provided in the documentation here
  2. Attempt to deploy this configuration
  3. See an error similar to the above
  4. Replace the underscore with . or - and see the error resolve

Expected behavior
The documentation should be updated such that the names used for the mapping are valid values for metadata.name

Versions (please complete the following information):

  • Ambassador: 0.70.0
  • Kubernetes environment: Amazon EKS
  • Version: 1.12.3
@stale
Copy link

stale bot commented Jul 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Jul 21, 2019
@richarddli
Copy link
Contributor

Not sure if this is still an issue, but if so, a documentation PR would be appreciated!

@stale stale bot removed the stale Issue is stale and will be closed label Jul 21, 2019
@stale
Copy link

stale bot commented Sep 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue is stale and will be closed label Sep 19, 2019
@stale stale bot closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue is stale and will be closed
Projects
None yet
Development

No branches or pull requests

2 participants