Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emissary should verify that TLS secrets contain valid PEM #3821

Closed
kflynn opened this issue Sep 22, 2021 · 1 comment
Closed

Emissary should verify that TLS secrets contain valid PEM #3821

kflynn opened this issue Sep 22, 2021 · 1 comment
Assignees
Labels
t:debt Piece of accumulated technical debt w:5 Targeted for fifth week of development cycle
Milestone

Comments

@kflynn
Copy link
Member

kflynn commented Sep 22, 2021

If you point a TLSContext at a secret containing bogus junk, Emissary will happily try to use it, but Envoy validation will fail. There's no real point in allowing Emissary to pass such a broken secret to Envoy -- we can, and should, validate it syntactically before attempting to use it at all.

@khussey khussey added the t:debt Piece of accumulated technical debt label Oct 13, 2021
@khussey khussey added this to the 2021 Cycle 7 milestone Oct 13, 2021
@khussey khussey added the w:3 Targeted for third week of development cycle label Oct 25, 2021
@khussey khussey added w:4 Targeted for fourth week of development cycle and removed w:3 Targeted for third week of development cycle labels Nov 2, 2021
@khussey khussey modified the milestones: 2021 Cycle 7, 2022 Cycle 1 Jan 4, 2022
@khussey khussey removed the w:4 Targeted for fourth week of development cycle label Jan 5, 2022
@khussey khussey added the w:5 Targeted for fifth week of development cycle label Jan 27, 2022
@khussey
Copy link
Contributor

khussey commented Feb 11, 2022

This has been addressed in Emissary-ingress 2.2, which is now available.

@khussey khussey closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:debt Piece of accumulated technical debt w:5 Targeted for fifth week of development cycle
Projects
None yet
Development

No branches or pull requests

2 participants