Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre.commit failed with ontology.py #415

Closed
sygout opened this issue May 23, 2022 · 6 comments
Closed

Pre.commit failed with ontology.py #415

sygout opened this issue May 23, 2022 · 6 comments

Comments

@sygout
Copy link
Collaborator

sygout commented May 23, 2022 •
edited
Loading

I got a problem with pre.commit for ontology.py related to pylint.

Error message are like:
Parameter 'fileobj' has been renamed to 'filename' in overridden 'Ontology.load' methodPylint(W0237:arguments-renamed)
@francescalb
Copy link
Collaborator

Seems to be working now, so I close this.

@sygout sygout reopened this Aug 16, 2022
@sygout
Copy link
Collaborator Author

sygout commented Aug 16, 2022

Was it tested on both Linux and Windows (just in case there are OS differences)?

@francescalb
Copy link
Collaborator

I do not get the same error anywhere. Can you reproduce it? If not I think we should close it..

@sygout
Copy link
Collaborator Author

sygout commented Aug 16, 2022

Should I test on branch master?

@francescalb
Copy link
Collaborator

yes, or make a new branch out of master.

@sygout
Copy link
Collaborator Author

sygout commented Aug 16, 2022

tested and no complain from pylint

@sygout sygout closed this as completed Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sygout @francescalb