Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

your code sucks #11

Open
whypet opened this issue Mar 1, 2021 · 2 comments
Open

your code sucks #11

whypet opened this issue Mar 1, 2021 · 2 comments

Comments

@whypet
Copy link

whypet commented Mar 1, 2021

No description provided.

@luxicajs
Copy link

+1

@real2two
Copy link

+1 To clarify why your code sucks,

  • First of all, why do you need a (function () {})(); in the first place? Also, you could've simplified that into (() => { codehere; })();?
  • You "use strict";, but then you spam a ton of vars. They are global variables, and "use strict"; is made sure you don't accidentally do that. You could've used a ton of consts and lets on your code.
  • You used a ton of unnecessary "===".
  • if () { } else if () { } else if () { } else if () { } else if () { } else if () { } else if () { } else if () { } else if () { } else if () { } else if () { } else {}; I don't think I need to explain this.
  • etc I gtg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants