From d1b58d0c230f160b85a1a6459f0331a4bd9356f1 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 18 Apr 2024 12:03:47 +0800 Subject: [PATCH] Version Packages (#551) Co-authored-by: github-actions[bot] --- .changeset/assign-player-after-game-end.md | 12 ------------ .changeset/lobby-fail.md | 10 ---------- lib/@empirica/core/CHANGELOG.md | 20 ++++++++++++++++++++ lib/@empirica/core/package.json | 2 +- 4 files changed, 21 insertions(+), 23 deletions(-) delete mode 100644 .changeset/assign-player-after-game-end.md delete mode 100644 .changeset/lobby-fail.md diff --git a/.changeset/assign-player-after-game-end.md b/.changeset/assign-player-after-game-end.md deleted file mode 100644 index b7c89cad..00000000 --- a/.changeset/assign-player-after-game-end.md +++ /dev/null @@ -1,12 +0,0 @@ ---- -"@empirica/core": patch ---- - -Fix reassign Player to a new Game after they played and finished a first Game. - -There were 2 problems: - -- the `player.get("ended")` field was not cleared -- the reassignment would not trigger the game to start if the introDone was not - reset (you don't want the player to go through intro steps again), since we - would never get the introDone signal, and just sit there... diff --git a/.changeset/lobby-fail.md b/.changeset/lobby-fail.md deleted file mode 100644 index 434daf23..00000000 --- a/.changeset/lobby-fail.md +++ /dev/null @@ -1,10 +0,0 @@ ---- -"@empirica/core": patch ---- - -Fix lobby fail strategy and similar straight to exit steps cases. - -There was a check for the presence of the `player.game` object in front of the -exit steps. If the game never starts, the `player.game` object is never -created, and the exit steps are never executed. This also addresses the case -where the player is never assigned a game at all (custom assignment). diff --git a/lib/@empirica/core/CHANGELOG.md b/lib/@empirica/core/CHANGELOG.md index f9d4fabc..7f25d2ab 100644 --- a/lib/@empirica/core/CHANGELOG.md +++ b/lib/@empirica/core/CHANGELOG.md @@ -1,5 +1,25 @@ # @empirica/core +## 1.11.1 + +### Patch Changes + +- 992d5f1: Fix reassign Player to a new Game after they played and finished a first Game. + + There were 2 problems: + + - the `player.get("ended")` field was not cleared + - the reassignment would not trigger the game to start if the introDone was not + reset (you don't want the player to go through intro steps again), since we + would never get the introDone signal, and just sit there... + +- 97c6837: Fix lobby fail strategy and similar straight to exit steps cases. + + There was a check for the presence of the `player.game` object in front of the + exit steps. If the game never starts, the `player.game` object is never + created, and the exit steps are never executed. This also addresses the case + where the player is never assigned a game at all (custom assignment). + ## 1.11.0 ### Minor Changes diff --git a/lib/@empirica/core/package.json b/lib/@empirica/core/package.json index a0fbb9c8..9800d9b5 100644 --- a/lib/@empirica/core/package.json +++ b/lib/@empirica/core/package.json @@ -1,6 +1,6 @@ { "name": "@empirica/core", - "version": "1.11.0", + "version": "1.11.1", "description": "Empirica Core", "author": "Nicolas Paton ", "license": "Apache-2.0",