Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for conditionally excluding all handwritten JS code for SDL. #2730

Closed
juj opened this issue Aug 27, 2014 · 3 comments
Closed

Add support for conditionally excluding all handwritten JS code for SDL. #2730

juj opened this issue Aug 27, 2014 · 3 comments

Comments

@juj
Copy link
Collaborator

juj commented Aug 27, 2014

Currently we have SDL code in at least src/library_sdl.js and some also in src/library_browser.js. Alon added link flags -s NO_FILESYSTEM=1 and -s NO_BROWSER=1 in relation to #2545 , and in the same style, we should add a link flag -s NO_SDL=1 or similar, which would strip out all the handwritten JS code that implements Emscripten's SDL 1.3.

The motivation for this is with our SDL 2 implementation, which seems to have some bits still using these handwritten JS paths, so this flag would help explicitly confirm that the SDL 2 port would properly use only the SDL2 code. Also, this would secondarily benefit other codebases to allow them explicitly opt out of linking to SDL at all.

@juj juj added SDL labels Aug 27, 2014
@kripken
Copy link
Member

kripken commented Aug 27, 2014

Also we should make -lSDL when linking turn it on, and default it to off.

@kripken
Copy link
Member

kripken commented May 20, 2015

Note that using SDL_mixer from our JS code is possible with SDL2. So this flag would only need to limit core SDL stuff, I suppose.

@juj juj mentioned this issue Oct 24, 2016
@stale
Copy link

stale bot commented Aug 31, 2019

This issue has been automatically marked as stale because there has been no activity in the past 2 years. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Aug 31, 2019
@stale stale bot closed this as completed Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants