You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should add a README to our scripts directory, explaining that we're using the GitHub "scripts to pull them all" pattern, and show how that ties in with our test and publish workflows.
That'd also be a good opportunity for a bit of clean-up.
It might be neatest for our scripts directory to strictly have a 1:1 mapping with the steps we have in our workflows.
$ ls -1 ./scripts/
build
check
clean # This doesn't exist in a workflow.
coverage # Called into by `test` when running locally.
install
lint # This doesn't exist in a workflow.
publish
test
unasync # Called into by `check` and `lint`
Perhaps a neater approach would be...
scripts/install - When running locally this should always start by removing any existing venv, coverage and build directories. We don't need scripts/clean then.
scripts/check and scripts/lint - I'd suggest we just have scripts/lint. Run scripts/lint --fix to update files in-place.
scripts/unasync - Should be a separate step in the workflow. Run scripts/unasync --fix to update files in-place.
So that each script is always a single workflow step.
The text was updated successfully, but these errors were encountered:
Prompted by @agronholm on our chat channel.
We should add a
README
to ourscripts
directory, explaining that we're using the GitHub "scripts to pull them all" pattern, and show how that ties in with ourtest
andpublish
workflows.That'd also be a good opportunity for a bit of clean-up.
It might be neatest for our scripts directory to strictly have a 1:1 mapping with the steps we have in our workflows.
Here's how our two workflows currently look...
And our scripts...
Perhaps a neater approach would be...
scripts/install
- When running locally this should always start by removing any existingvenv
,coverage
andbuild
directories. We don't needscripts/clean
then.scripts/check
andscripts/lint
- I'd suggest we just havescripts/lint
. Runscripts/lint --fix
to update files in-place.scripts/unasync
- Should be a separate step in the workflow. Runscripts/unasync --fix
to update files in-place.So that each script is always a single workflow step.
The text was updated successfully, but these errors were encountered: