Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTPS proxies. #722

Closed
2 of 3 tasks
tomchristie opened this issue Jun 14, 2023 · 1 comment · Fixed by #786
Closed
2 of 3 tasks

Support HTTPS proxies. #722

tomchristie opened this issue Jun 14, 2023 · 1 comment · Fixed by #786
Labels
enhancement New feature or request

Comments

@tomchristie
Copy link
Member

tomchristie commented Jun 14, 2023

Of the following proxy cases...

  • HTTP proxy + HTTP destination
  • HTTP proxy + HTTPS destination
  • HTTPS proxy + HTTP destination
  • HTTPS proxy + HTTPS destination

...we currently only support the first two.

In order to support the other two cases we should add a proxy_ssl_context argument, which should be used for the SSL connection to the proxy itself.

Implementing the last case will be a little complicated for the sync case, since the stdlib wrap_socket behaviour doesn't support TLS-in-TLS.

Note that the urllib3 project documentation, do a good job of documenting the possible proxy types.

Also see the httpx issue for this... encode/httpx#1434


Progress...

  • Supported in standard sync.
  • Supported in asyncio.
  • Supported in trio.
@tomchristie tomchristie added the enhancement New feature or request label Jun 14, 2023
@tomchristie
Copy link
Member Author

I think that closing #721 is a necessary precursor to resolving this enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant