Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support digest authentication for HTTP proxies. #2033

Closed
tomchristie opened this issue Jan 17, 2022 Discussed in #2028 · 6 comments
Closed

Support digest authentication for HTTP proxies. #2033

tomchristie opened this issue Jan 17, 2022 Discussed in #2028 · 6 comments
Labels
enhancement New feature or request proxies Issues related to HTTP and SOCKS proxies wontfix

Comments

@tomchristie
Copy link
Member

tomchristie commented Jan 17, 2022

Escalating discussion #2028 into an issue.

HTTP proxies are sometimes configured to use digest authentication.
Right now we only support basic authentication with HTTP proxies.
It'd be worthwhile to also support digest - which requires following up the initial CONNECT request to the proxy with a subsequent authentication request before the proxy tunnel is established.

Here's the original discussion...

Originally posted by raffaem January 13, 2022
Does httpx support DigestAuthentication for proxies, and if so, can you connect to HTTPS websites through a proxy that requires DigestAuthentication?

requests-toolbet has a HTTPProxyDigestAuth class, but it does not allow you to connect to HTTPS through the proxy.

Apparently that feature won't be implemented in the foreseeable future in requests.

The only working implementation that I have found, and which allows you to connect to HTTPS websites through the proxy, is this one, which was provided in this StackOverflow post.

Does httpx support this feature, or will it support it?

@tomchristie tomchristie added enhancement New feature or request proxies Issues related to HTTP and SOCKS proxies labels Jan 17, 2022
@stale
Copy link

stale bot commented Feb 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 20, 2022
@tomchristie
Copy link
Member Author

Still valid thx, @Stale bot.

@stale stale bot removed the wontfix label Feb 21, 2022
@stale
Copy link

stale bot commented Mar 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 25, 2022
@stale
Copy link

stale bot commented Oct 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 15, 2022
@tomchristie
Copy link
Member Author

I think we should consider closing this since we've only had one person ever request this.

There's enough documentation and pointers around httpcore for someone who's interested to be able to start tackling it. If someone ends up interested and invested in resolving that, then I think that'd be a good indicator that it'd be worth re-opening.

Seem valid @encode/maintainers?

@tomchristie
Copy link
Member Author

I'm going to close this ticket off for now - if someone bumps into this as a requirement please let us know.
Otherwise / until then, we'll be treating this as out of scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proxies Issues related to HTTP and SOCKS proxies wontfix
Projects
None yet
Development

No branches or pull requests

1 participant