Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curio still mentioned in docs although unsupported since 0.21.0 #2233

Closed
florimondmanca opened this issue May 17, 2022 · 5 comments · Fixed by #2240
Closed

Curio still mentioned in docs although unsupported since 0.21.0 #2233

florimondmanca opened this issue May 17, 2022 · 5 comments · Fixed by #2240
Assignees
@kcoderhtml
Labels
docs Changes to the documentation good first issue Good for newcomers

Comments

@florimondmanca
Copy link
Member

florimondmanca commented May 17, 2022 •
edited
Loading

See discussion #2232, see also comment #1953 (comment)

Curio is still mentioned in documentation here as being supported: https://www.python-httpx.org/async/#curio

But it was dropped in version 0.21.0, when HTTPCore dropped curio support as part of the 0.14.0 redesign.

There is discussion on getting curio support back: #1953

But right now the documentation is incorrect and curio should be dropped from it.
@florimondmanca florimondmanca added good first issue Good for newcomers docs Changes to the documentation labels May 17, 2022
@kcoderhtml
Copy link
Contributor

I am a new developer and would be willing to do this. Are there any guidelines or special instructions for this project?

@florimondmanca
Copy link
Member Author

Hi @kcoderhtml, sure, feel free to read through the Contributing Guide if you need info on settings things up! https://www.python-httpx.org/contributing/

@kcoderhtml
Copy link
Contributor

Thanks!

@kcoderhtml
Copy link
Contributor

Can you assign me to this?

@kcoderhtml kcoderhtml mentioned this issue May 21, 2022
Merged
1 task
@kcoderhtml
Copy link
Contributor

Completed! Awaiting approval for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcoderhtml kcoderhtml

Labels
docs Changes to the documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed curio from async.md kcoderhtml/httpx
2 participants
@florimondmanca @kcoderhtml