Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtk insists that a function is in ctors, but it's in text #36

Closed
ribbanya opened this issue Feb 1, 2024 · 1 comment
Closed

dtk insists that a function is in ctors, but it's in text #36

ribbanya opened this issue Feb 1, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ribbanya
Copy link
Contributor

ribbanya commented Feb 1, 2024

Repository URL

https://github.com/ribbanya/melee/tree/8daa8eb261ccd111d7595bc73405607b2fb4cd5d

Game Name

Super Smash Bros. Melee

Game Version

GALE01

Description

dtk keeps placing a function, whose definition is in .text, but is referenced from .ctors, in .ctors. Well, more accurately, it keeps creating a ctors split where that function is. The function is __sinit_trigf_c.

I'm not sure this is a bug. I would be entirely unsurprised if this is due to us doing something wrong, since as you can see __ctors are not properly implemented in C.

@ribbanya ribbanya added the bug Something isn't working label Feb 1, 2024
@ribbanya
Copy link
Contributor Author

ribbanya commented Feb 2, 2024

As per Discord discussion, doesn't seem to be a dtk bug. Need to change compiler flags for certain parts of melee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant