Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endo: Support cyclic dependencies across compartments #427

Closed
kriskowal opened this issue Aug 22, 2020 · 1 comment · Fixed by #433
Closed

Endo: Support cyclic dependencies across compartments #427

kriskowal opened this issue Aug 22, 2020 · 1 comment · Fixed by #433

Comments

@kriskowal
Copy link
Member

Agoric contracts use these mutually-dependent packages:

To facilitate this, Endo will need to implement a two-pass assemble method and not use moduleMapHook instead of moduleMap for all dependencies. In the first, flat pass over the compartment map, it will construct all of the compartments, passing the evolving compartment map to each child compartment. This pass will no longer be recursive and will not detect import cycles. The load phase will allow cross-linkage by referring to the compartment map in the moduleMapHook.

@kriskowal kriskowal mentioned this issue Aug 22, 2020
36 tasks
@kriskowal kriskowal linked a pull request Aug 26, 2020 that will close this issue
@kriskowal
Copy link
Member Author

Done and released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant