Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compartment mapper: validate compartment map JSON #601

Closed
kriskowal opened this issue Mar 6, 2021 · 1 comment · Fixed by #1085
Closed

Compartment mapper: validate compartment map JSON #601

kriskowal opened this issue Mar 6, 2021 · 1 comment · Fixed by #1085
Assignees
Labels

Comments

@kriskowal
Copy link
Member

Currently, the compartment mapper takes for granted that the compartment map is a valid instance of its purported schema. TypeScript calls us out on this, so there’s a forced cast in place in import-archive.js and a note to write a TS compliant validator to visit and assert the entire JSON shape.

#599 (comment)

@Tartuffo
Copy link

Tartuffo commented Feb 3, 2022

@kriskowal This does not have an area label that is covered by our weekly tech / planning meetings. Can you assign the proper label? We cover: agd, agoric-cosmos, amm, core economy, cosmic-swingset, endo, getrun, governance, installation-bundling, metering, run-protocol, staking, swingset, swingset-runner, token economy, wallet, zoe contract,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants