Stop enabling O.p.constructor to be overridden by assignment. #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is interesting that this PR fails a CI test https://github.com/Agoric/SES-shim/pull/587/checks?check_run_id=1995064245 but #586 does not. I do not understand this. |
erights
force-pushed
the
markm-normalize-o-p-constructor
branch
from
292d722
to
18f8fdd
Compare
erights
force-pushed
the
markm-normalize-o-p-constructor
branch
from
18f8fdd
to
3d1067b
Compare
erights
changed the title
|
@dckc @michaelfig This is finally a candidate for merging, and so ready for review. |
michaelfig
approved these changes
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Agoric/agoric-sdk#2324
Fixes #477
To enable
Object.prototype.constructorto be overridden by assignment, we needed to make it into an accessor property. However, this confused the Node console as explained at Agoric/agoric-sdk#2324 . But not doing so had been blocked by our dependency on acorn 7 which performs such an assignment. That dependency has now been fixed by#588
and
Agoric/agoric-sdk#2549
so we can proceed.