Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong handling of 'undocumented' attributes with jsdoc 3.6.x #99

Open
alxroyer opened this issue Sep 2, 2019 · 2 comments
Open

Wrong handling of 'undocumented' attributes with jsdoc 3.6.x #99

alxroyer opened this issue Sep 2, 2019 · 2 comments
Labels

Comments

@alxroyer
Copy link
Contributor

alxroyer commented Sep 2, 2019

As noticed by jsdoc#1672, jsdoc 3.6.x output differs from 3.5.x, especially on undocumented attributes strangely set to true while the comment attribute is correctly set with some user comment.

The effect for tsd-jsdoc is that such doclets are not managed anymore.

Steps to reproduce :

  • checkout tsd-jsdoc, run npm install but then force the installation of jsdoc with version 3.6.3.
  • npm run build
  • npm run test => failure
@englercj
Copy link
Owner

englercj commented Sep 3, 2019

Yeah there are a bunch of backwards incompatible changes to jsdoc 3.6. I really wish they had done a major release.

I think in this lib we need to update to work with 3.6, and change how we determine exports (a la #100), then do a major release on our side.

@alxroyer
Copy link
Contributor Author

alxroyer commented Sep 7, 2019

I've just committed a sample of code to fix this problem.
See changes on publish.ts in PR#98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants