Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate python 2.x dependency introduced by sass #233

Open
micahstubbs opened this issue May 15, 2019 · 3 comments
Open

investigate python 2.x dependency introduced by sass #233

micahstubbs opened this issue May 15, 2019 · 3 comments
Assignees

Comments

@micahstubbs
Copy link
Collaborator

investigate python 2.x dependency introduced by sass

it seems that npm install will now fail on a machine with python 3.x

I think the culprit is node-gyp which builds node-sass from source.

env

macOS 10.14.5 Beta
node v11.10.0
npm 6.8.0
@micahstubbs micahstubbs self-assigned this May 15, 2019
@micahstubbs
Copy link
Collaborator Author

ideally, we would not depend on any particular python version at all.

@hydrosquall
Copy link
Contributor

hydrosquall commented May 19, 2019

Another option might be to upgrade node-sass in this repo, since 4.12.0 installed cleanly without error on my device over in blockbuilder-search. I tried it in this repo too and that installed without error even without upgrading webpack.

@micahstubbs
Copy link
Collaborator Author

ah, that is good to know!

eventually, I'd like to move away from sass entirely to css-modules or some css-in-js solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants