Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add an option for dark mode to respect system theme #7

Closed
LuminarySage opened this issue Dec 13, 2019 · 4 comments
Closed

Comments

@LuminarySage
Copy link

Following Google's guidelines at https://developer.android.com/guide/topics/ui/look-and-feel/darktheme
image

@enricocid
Copy link
Owner

enricocid commented Dec 13, 2019

This is already in my to-do list, I already have a working implementation from music player go 4.0.0 version I'm going to release within the next days (light, dark and auto, with auto following the system in Android q and battery levels in pre-q as suggested in guidelines).
Unfortunately, as opposed to music player go that does not implement any material component, currently it is not possible to add this option in VDH as DayNight theme is still not available in material components theme, that is the theme I must apply to the app to ensure the correct behaviour of the material component 'app bar: bottom'. The app will crash if I apply Appcompat.DayNight theme.
So we have to wait for DayNight theme to be released in next stable version (can't use alpha or beta releases in the project) of the material components library.

@enricocid
Copy link
Owner

enricocid commented Jan 27, 2020

Just to inform You that as soon as I finish working with the next MPGO update, I will implement day night theme on VDH too. It will be available very soon ,within this week hopefully :)

@LuminarySage
Copy link
Author

Thanks for the update! Really appreciate your work

@enricocid
Copy link
Owner

enricocid commented Jan 27, 2020

Thanks!
The feature has been implemented. I'm gonna release it within the next few days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants