Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monekin icon is cropped in the initial splash screen #219

Open
4 tasks done
shinebrillant opened this issue Oct 5, 2024 · 7 comments
Open
4 tasks done

Monekin icon is cropped in the initial splash screen #219

shinebrillant opened this issue Oct 5, 2024 · 7 comments
Labels
help wanted Extra help is needed from the community type: bug Something isn't working

Comments

@shinebrillant
Copy link
Contributor

shinebrillant commented Oct 5, 2024

Prerequisites

Current Behavior

When Monekin is opened for the first time, the four corners of the icon are cropped.

nsmail-3

Expected Behavior

The corners of the Monekin icon should be rounded.

Steps to Reproduce

  1. Delete the Monekin app in the background of your mobile phone.
  2. Open the Monekin app.

Additional Information

No response

@shinebrillant shinebrillant added the type: bug Something isn't working label Oct 5, 2024
@enrique-lozano enrique-lozano added the help wanted Extra help is needed from the community label Oct 20, 2024
@enrique-lozano
Copy link
Owner

The icon is cropped in the splash screen, I added the help wanted label to see if someone can help with this, since I don't have time right now to investigate this issue

@vincius0000
Copy link
Contributor

What OS does this issue occur on? I've ran main branch in Android Pixel emulator and on splash screen the icon is perfectly rounded. I've experimented with some changes as well, but I could see the same result.

Does this issue still persist?

@vincius0000
Copy link
Contributor

vincius0000 commented Oct 27, 2024

@enrique-lozano this seems to be an issue with Android 12+.

On another Github for MAUI this was raised (dotnet/maui#9886), the issue is better described in following issue
dotnet/maui#9794

There are cetain requirements that Icon must follow
https://developer.android.com/develop/ui/views/launch/splash-screen#elements

I did experiments on another project - scaling down the icon helped me.
Also, I could replicate this here only after Gradle upgrade.

@shinebrillant
Copy link
Contributor Author

I use pixel 6 pro, the system is android 14, and I still have this problem after upgrading to 15.

@enrique-lozano
Copy link
Owner

Hi @shinebrillant @vincius0000. This is probably fixed in #211, please test this branch if you can and see if the issue still exists.

@vincius0000
Copy link
Contributor

@enrique-lozano I have the same
image

I would attempt to rebuild the icon files using Android Studio, just to make sure icon follows the requirements for Android 12+. Then in relevant file I would reference ic_launcher_round.xml and if things don't look round, then try to edit launch_background.xml

@RelapsingCertainly
Copy link

Something I've noticed is, the icon is only weird in dark mode. In light mode, the icon is smaller and does not clip

@enrique-lozano enrique-lozano changed the title Monekin open icon Monekin icon is cropped in the initial splash screen Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra help is needed from the community type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants