Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account form hints need translation #226

Open
4 tasks done
vincius0000 opened this issue Oct 28, 2024 · 2 comments
Open
4 tasks done

Account form hints need translation #226

vincius0000 opened this issue Oct 28, 2024 · 2 comments
Labels
good first issue Good for newcomers. Beginner friendly tasks Translations Translations, text changes or anything related to localization type: bug Something isn't working

Comments

@vincius0000
Copy link
Contributor

Prerequisites

Current Behavior

Within account_form.dart some hint texts are hardcoded, ex:
hintText: 'Ex.: My account'

Expected Behavior

Both 'Ex.:' and 'My account' words should be written in selected language.

Steps to Reproduce

Start creating new account.

Additional Information

No response

@vincius0000 vincius0000 added the type: bug Something isn't working label Oct 28, 2024
@vincius0000
Copy link
Contributor Author

There are more I've found, import_csv.dart

return Column(
    children: [
      buildColumnSelector(
        value: notesColumn,
        labelText: 'Note column',
        headersToSelect: headersToSelect,
        onChanged: (value) {
          setState(() {
            notesColumn = value;
          });
        },
      ),
      const SizedBox(height: 16),
      buildColumnSelector(
        value: titleColumn,
        labelText: 'Title column',
        headersToSelect: headersToSelect,
        onChanged: (value) {
          setState(() {
            titleColumn = value;
          });
        },
      ),
    ],
  );

I've had the "Welcome back!" at home page mistranslated as well, I did have snackbar notification in wrong translation too after full export, but I'm looking into that on why that happen. The snackbar was in Spanish and I'm trying to see where it's configured like so.

@enrique-lozano
Copy link
Owner

Yep, some translations are missing. We need to add the keys to the translations JSON files and then run dart dun slang. After that, we can use the new translationa

@enrique-lozano enrique-lozano added good first issue Good for newcomers. Beginner friendly tasks Translations Translations, text changes or anything related to localization labels Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers. Beginner friendly tasks Translations Translations, text changes or anything related to localization type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants