Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Image is not available #21

Open
peduarte opened this issue Sep 6, 2022 · 3 comments
Open

Error: Image is not available #21

peduarte opened this issue Sep 6, 2022 · 3 comments

Comments

@peduarte
Copy link

peduarte commented Sep 6, 2022

Hey there, I've been having issues loading the avatar for nicolo.eth. Here's a link to a minimal reproducible example: https://codesandbox.io/s/competent-colden-fuq4xy?file=/src/App.js

It works with all other ENS I've tried, but for some reason, it crashed with nicolo.eth

The Avatar Record on ENS is: eip155:1/erc721:0xabefbc9fd2f806065b4f3c237d4b59d9a97bcac7/25042 (apparently a Zora NFT)

Steps to reproduce:

Related: raycast/extensions#2816

Thanks!

@peduarte
Copy link
Author

peduarte commented Sep 6, 2022

Update: also happens on sammdec.eth - which also has the Avatar Record set to The Zora Contract (0xabefbc9fd2f806065b4f3c237d4b59d9a97bcac7)

@serenae-fansubs
Copy link

That's an issue with that NFT contract. The creators/devs behind that NFT project have not implemented ERC-721 correctly.

https://eips.ethereum.org/EIPS/eip-721#specification

The tokenURI method should point to a JSON file following the schema outlined in the spec, but their contract does not do this.

@peduarte
Copy link
Author

peduarte commented Sep 6, 2022

@serenae-fansubs makes sense! after a few hours of debugging with @sammdec we realised that too!

is it worth trying to catch this error from the library to prevent crashes?

on my current project, i'm basically ignoring checking for avatar if it uses the Zora Contract:
CleanShot 2022-09-06 at 19 47 26@2x

Just an idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants