Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete import #291

Open
mixmix opened this issue Nov 11, 2024 · 1 comment · May be fixed by #307
Open

complete import #291

mixmix opened this issue Nov 11, 2024 · 1 comment · May be fixed by #307
Assignees

Comments

@mixmix
Copy link
Contributor

mixmix commented Nov 11, 2024

We need to be able to import from seed, and for this to load the current state of that account into the config.

Namely, we need verifyingKeys to be loaded + stored.

QUESTION: if there are multiple instances, do we need to watch for vks being added from other places? (different issue)

@mixmix mixmix added this to the CLI completeness milestone Nov 12, 2024
@rh0delta
Copy link
Contributor

this can be handled fairly easily with the current state of the keyring and the entropy instance as a whole since we are still in debug mode (meaning all accounts attached will have the same address), how will we handle this once we are out of the aforementioned debug mode? one thought is to cycle through all the addresses and run the modifiableKeys api call to grab the public keys, but i don't believe that to be a performant process. i wonder if we can look into updating the sdk to perform this action?

@rh0delta rh0delta linked a pull request Nov 14, 2024 that will close this issue
8 tasks
@rh0delta rh0delta linked a pull request Nov 15, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants