From 0c07d3572fdfcd51f6f33b1d5db30bed3a937014 Mon Sep 17 00:00:00 2001 From: Jakub Sobon Date: Wed, 4 Jan 2023 15:06:11 +0000 Subject: [PATCH 1/3] Allow pipeline retries after artifacts were published. Signed-off-by: Jakub Sobon --- .azure-pipelines/pipelines.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azure-pipelines/pipelines.yml b/.azure-pipelines/pipelines.yml index 8ddfe734..ad3d5c05 100644 --- a/.azure-pipelines/pipelines.yml +++ b/.azure-pipelines/pipelines.yml @@ -64,4 +64,4 @@ stages: displayName: 'Publish the line coverage report' inputs: targetPath: $(System.DefaultWorkingDirectory)/salvo/coverage/html.zip - artifactName: CoverageReport + artifactName: CoverageReport-$(System.JobAttempt) From e3e24ef3bf98dc984e11b835e38af4e8b56542e2 Mon Sep 17 00:00:00 2001 From: Jakub Sobon Date: Wed, 4 Jan 2023 16:35:51 +0000 Subject: [PATCH 2/3] Disable coverage until it gets fixed. Signed-off-by: Jakub Sobon --- ci/do_ci.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ci/do_ci.sh b/ci/do_ci.sh index 618406a3..7f49b1c9 100755 --- a/ci/do_ci.sh +++ b/ci/do_ci.sh @@ -30,7 +30,9 @@ function test_salvo() { pushd salvo setup_salvo_venv - tools/coverage.sh + bazel test //... + # TODO(#187): Re-enable once coverage reporting is fixed. + # tools/coverage.sh popd } From c441574711ec5816fbbacff5581b3e696fcc1fa3 Mon Sep 17 00:00:00 2001 From: Jakub Sobon Date: Wed, 4 Jan 2023 16:53:59 +0000 Subject: [PATCH 3/3] Disable the coverage pipeline stage. Signed-off-by: Jakub Sobon --- .azure-pipelines/pipelines.yml | 47 +++++++++++++++++----------------- ci/do_ci.sh | 2 -- 2 files changed, 24 insertions(+), 25 deletions(-) diff --git a/.azure-pipelines/pipelines.yml b/.azure-pipelines/pipelines.yml index ad3d5c05..e26369aa 100644 --- a/.azure-pipelines/pipelines.yml +++ b/.azure-pipelines/pipelines.yml @@ -42,26 +42,27 @@ stages: parameters: ciTarget: $(CI_TARGET) -- stage: coverage - dependsOn: ["test"] - pool: "x64-large" - jobs: - - job: coverage - displayName: "do_ci.sh" - dependsOn: [] - strategy: - maxParallel: 1 - matrix: - coverage: - CI_TARGET: "coverage" - timeoutInMinutes: 120 - steps: - - template: bazel.yml - parameters: - ciTarget: $(CI_TARGET) - - task: PublishPipelineArtifact@1 - condition: always() - displayName: 'Publish the line coverage report' - inputs: - targetPath: $(System.DefaultWorkingDirectory)/salvo/coverage/html.zip - artifactName: CoverageReport-$(System.JobAttempt) +# TODO(#187): Re-enable once coverage reporting is fixed. +#- stage: coverage +# dependsOn: ["test"] +# pool: "x64-large" +# jobs: +# - job: coverage +# displayName: "do_ci.sh" +# dependsOn: [] +# strategy: +# maxParallel: 1 +# matrix: +# coverage: +# CI_TARGET: "coverage" +# timeoutInMinutes: 120 +# steps: +# - template: bazel.yml +# parameters: +# ciTarget: $(CI_TARGET) +# - task: PublishPipelineArtifact@1 +# condition: always() +# displayName: 'Publish the line coverage report' +# inputs: +# targetPath: $(System.DefaultWorkingDirectory)/salvo/coverage/html.zip +# artifactName: CoverageReport-$(System.JobAttempt) diff --git a/ci/do_ci.sh b/ci/do_ci.sh index 7f49b1c9..8c50f8b5 100755 --- a/ci/do_ci.sh +++ b/ci/do_ci.sh @@ -31,8 +31,6 @@ function test_salvo() { setup_salvo_venv bazel test //... - # TODO(#187): Re-enable once coverage reporting is fixed. - # tools/coverage.sh popd }