Skip to content

Commit

Permalink
Change non-null port -> non-zero port.
Browse files Browse the repository at this point in the history
Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
  • Loading branch information
ipuustin committed Mar 12, 2019
1 parent d97a770 commit c7d08b6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion source/common/upstream/upstream_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class HostDescriptionImpl : virtual public HostDescription {
// Setting the health check port to non-0 only works for IP-type addresses. Setting the port
// for a pipe address is a misconfiguration. Throw an exception.
throw EnvoyException(
fmt::format("Invalid host configuration: non-null port for non-IP address"));
fmt::format("Invalid host configuration: non-zero port for non-IP address"));
}
health_check_address_ =
health_check_config.port_value() == 0
Expand Down
2 changes: 1 addition & 1 deletion test/common/upstream/upstream_impl_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ TEST(HostImplTest, HealthPipeAddress) {
envoy::api::v2::core::Metadata::default_instance(),
envoy::api::v2::core::Locality().default_instance(), config, 1);
},
EnvoyException, "Invalid host configuration: non-null port for non-IP address");
EnvoyException, "Invalid host configuration: non-zero port for non-IP address");
}

class StaticClusterImplTest : public testing::Test, public UpstreamImplTestBase {};
Expand Down

0 comments on commit c7d08b6

Please sign in to comment.