-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --bootstrap-version
command line option
#16456
Comments
cc @htuch |
Yeah, we should probably do this at some point, let's have the dust settle first. #16274 stopped users doing anything dangerous here, so I think maybe clean this one up after next release. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions. |
Still available? |
Sure |
Is time to clean it? If so, I would like to take. |
If you want to work on the PR, we can merge it after 1.19 ships in early July. |
got, would do it after 1.19. /assign |
Will this option make sense again as the v4 API matures? |
@jpeach postmortem pending, but I think based on v2 -> v3 experiences, v4 is very far away (at least multiple years) if it happens at all. |
Fixed in #17724 |
description
once v2 has been fully removed the bootstrap-version no longer makes any sense (see https://www.envoyproxy.io/docs/envoy/latest/operations/cli#cmdoption-bootstrap-version)
apart from removing the cli option and related docs i think we also need to ensure that the logic for loading as v2 and upgrading is also removed
there is (also) some stuff in
api/envoy/config/core/v3/config_source.proto
that may need to changeThe text was updated successfully, but these errors were encountered: