Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --bootstrap-version command line option #16456

Closed
phlax opened this issue May 12, 2021 · 11 comments
Closed

Remove --bootstrap-version command line option #16456

phlax opened this issue May 12, 2021 · 11 comments
Assignees
Labels
api/v2 api/v3 Major version release @ end of Q3 2019 area/runtime help wanted Needs help!

Comments

@phlax
Copy link
Member

phlax commented May 12, 2021

description

once v2 has been fully removed the bootstrap-version no longer makes any sense (see https://www.envoyproxy.io/docs/envoy/latest/operations/cli#cmdoption-bootstrap-version)

apart from removing the cli option and related docs i think we also need to ensure that the logic for loading as v2 and upgrading is also removed

there is (also) some stuff in api/envoy/config/core/v3/config_source.proto that may need to change

@phlax phlax added triage Issue requires triage api/v2 api/v3 Major version release @ end of Q3 2019 area/runtime and removed triage Issue requires triage labels May 12, 2021
@phlax
Copy link
Member Author

phlax commented May 12, 2021

cc @htuch

@htuch
Copy link
Member

htuch commented May 13, 2021

Yeah, we should probably do this at some point, let's have the dust settle first. #16274 stopped users doing anything dangerous here, so I think maybe clean this one up after next release.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 12, 2021
@phlax phlax added help wanted Needs help! and removed stale stalebot believes this issue/PR has not been touched recently labels Jun 12, 2021
@daixiang0
Copy link
Member

Still available?

@htuch
Copy link
Member

htuch commented Jun 29, 2021

Sure

@daixiang0
Copy link
Member

Yeah, we should probably do this at some point, let's have the dust settle first. #16274 stopped users doing anything dangerous here, so I think maybe clean this one up after next release.

Is time to clean it? If so, I would like to take.

@htuch
Copy link
Member

htuch commented Jun 30, 2021

If you want to work on the PR, we can merge it after 1.19 ships in early July.

@daixiang0
Copy link
Member

got, would do it after 1.19.

/assign

@jpeach
Copy link
Contributor

jpeach commented Jul 17, 2021

Will this option make sense again as the v4 API matures?

@htuch
Copy link
Member

htuch commented Jul 19, 2021

@jpeach postmortem pending, but I think based on v2 -> v3 experiences, v4 is very far away (at least multiple years) if it happens at all.

@htuch
Copy link
Member

htuch commented Sep 12, 2021

Fixed in #17724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/v2 api/v3 Major version release @ end of Q3 2019 area/runtime help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

4 participants