Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter: Hide Struct from filter interface #3155

Closed
lizan opened this issue Apr 20, 2018 · 2 comments
Closed

filter: Hide Struct from filter interface #3155

lizan opened this issue Apr 20, 2018 · 2 comments
Assignees
@lizan
Labels
enhancement Feature requests. Not bugs or questions.
Milestone
1.7.0

Comments

@lizan
Copy link
Member

lizan commented Apr 20, 2018

Description:
We should not expose Struct (or Any, or similar) to filter interface. When Envoy knows the protobuf types filter needs, Envoy performs the conversion, this allows migrating the opaque config format in future.

Details: #3128 (comment)

@htuch
@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label Apr 20, 2018
@mattklein123
Copy link
Member

@lizan I assume the idea here is to bring back the factory function we had before, and pair it with the route object construction? This seems fine to me. Can you do the PR?

@mattklein123 mattklein123 added this to the 1.7.0 milestone Apr 20, 2018
@lizan
Copy link
Member Author

lizan commented Apr 20, 2018

Yes that's correct. I can do this.

@lizan lizan mentioned this issue Apr 21, 2018
Merged
@lizan lizan mentioned this issue Sep 19, 2018
Merged
@htuch htuch mentioned this issue Sep 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lizan lizan

Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
2 participants
@lizan @mattklein123