Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clang to build release binary. #4158

Closed
PiotrSikora opened this issue Aug 15, 2018 · 3 comments · Fixed by #6841
Closed

Use clang to build release binary. #4158

PiotrSikora opened this issue Aug 15, 2018 · 3 comments · Fixed by #6841
Labels
Milestone

Comments

@PiotrSikora
Copy link
Contributor

From the original PR:

Loading 1000 static listeners in a binary built with gcc takes ~51s,
but only ~1.5s (34x faster) in a binary built with clang.

The problem was mitigated by #4117, which reduced number of preallocated elements in the LcTrie, though the difference in performance still exists (due to unpacked LcNode).

cc @mattklein123 @htuch @alyssawilk @lizan

@PiotrSikora
Copy link
Contributor Author

Note that we'd need to use gcc on CentOS (assuming we want to provide release binaries for it).

@mattklein123
Copy link
Member

Note that we'd need to use gcc on CentOS (assuming we want to provide release binaries for it).

We don't provide binaries for CentOS today so I don't think we would start doing so unless someone in the community wants to properly resource CentOS support independently.

@uromahn
Copy link

uromahn commented Sep 25, 2018

@mattklein123 We are planning to introduce Envoy across our entire system and CentOS support is an absolute "must" for us. We are running our entire system on it and having everything re-certified with a different OS is just too expensive and time consuming.

I personally don't object the switch to clang as long as the current build for CentOS stays there.
I have experimented building a newer toolchain with clang6 for CentOS from source but the build is painfully slow and I wasn't getting much success so far (since I am not a C++ expert).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants