Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different unit of timestamp in metrics_service in linux and macos #4278

Closed
lomik opened this issue Aug 28, 2018 · 5 comments
Closed

Different unit of timestamp in metrics_service in linux and macos #4278

lomik opened this issue Aug 28, 2018 · 5 comments
Labels

Comments

@lomik
Copy link
Contributor

lomik commented Aug 28, 2018

Description:
Envoy sends a different value for timestamps to metrics_service in linux and macos: nanos in linux and micros in macos.
Problem reproduced in 1.7.0 and in current master.

Repro steps:
Sample "metrics_service" and envoy config are here: https://github.com/lomik/envoy-issue/tree/master/metric_service_timestamp

Macos output:

&io_prometheus_client.Metric{Label:[]*io_prometheus_client.LabelPair(nil), Gauge:(*io_prometheus_client.Gauge)(nil), Counter:(*io_prometheus_client.Counter)(nil), Summary:(*io_prometheus_client.Summary)(0xc0001d61b0), Untyped:(*io_prometheus_client.Untyped)(nil), Histogram:(*io_prometheus_client.Histogram)(nil), TimestampMs:1535464990220755}

# TimestampMs:1535464990220755

Linux output:

&io_prometheus_client.Metric{Label:[]*io_prometheus_client.LabelPair(nil), Gauge:(*io_prometheus_client.Gauge)(0xc420026818), Counter:(*io_prometheus_client.Counter)(nil), Summary:(*io_prometheus_client.Summary)(nil), Untyped:(*io_prometheus_client.Untyped)(nil), Histogram:(*io_prometheus_client.Histogram)(nil), TimestampMs:1535465054722145763}

# TimestampMs:1535465054722145763
@lizan
Copy link
Member

lizan commented Aug 30, 2018

@jmarantz Can you take a look on this? cc @zuercher for macOS.

@lizan lizan added help wanted Needs help! bug labels Aug 30, 2018
@jmarantz
Copy link
Contributor

This is already being addressed in #4288 ?

@zyfjeff
Copy link
Member

zyfjeff commented Aug 31, 2018

Sorry, I didn't explain it in the issue in time, I am already dealing with this problem.

@jmarantz
Copy link
Contributor

agreed; please assign to @zyfjeff

@zuercher
Copy link
Member

zuercher commented Sep 4, 2018

I think assignees need to be members of the org. Leaving it unassigned for now.

@htuch htuch closed this as completed in 7707c3b Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants