Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add injectDataToFilterChain(data, end_stream) methods to NetworkFilter callbacks #6640

Closed
yskopets opened this issue Apr 18, 2019 · 2 comments · Fixed by #6750
Closed

Add injectDataToFilterChain(data, end_stream) methods to NetworkFilter callbacks #6640

yskopets opened this issue Apr 18, 2019 · 2 comments · Fixed by #6750
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@yskopets
Copy link
Member

Title: Similarly to HTTP use case, add injectDataToFilterChain(data, end_stream) methods to NetworkFilter callbacks

Description:

Recently, new methods have been added to StreamFilterCallbacks in order to support low bandwidth simulation (see #6242):

  • StreamDecoderFilterCallbacks::injectDecodedDataToFilterChain(data, end_stream)
  • StreamEncoderFilterCallbacks::injectEncodedDataToFilterChain(data, end_stream)

It would be useful to have methods with the same semantics in the context of NetworkFilters as well.

Example use cases include:

@mattklein123
Copy link
Member

@yskopets thanks for opening, I just checked and yes, you are correct, we will need these new APIs to do similar things as what we are doing for HTTP. Conveniently, the implementation should be much easier. Will mark help wanted.

@mattklein123 mattklein123 added enhancement Feature requests. Not bugs or questions. help wanted Needs help! labels Apr 18, 2019
@yskopets
Copy link
Member Author

@mattklein123 Great! I will try to implement it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
2 participants