[benchmark] ASSERT failure in //test/common/common/utility_speed_test

[antoniovicente]

Description:
//test/common/common/utility_speed_test fails due to ASSERT failure when run in debug mode.
Relevant code:
interval_set.insert(-2, 23);
https://github.com/envoyproxy/envoy/blob/master/test/common/common/utility_speed_test.cc#L249

-2 as a size_t which is an unsigned type is larger than 23.

Repro steps:
$ bazel run //test/common/common:utility_speed_test

Logs:
BM_RemoveTokensLong/4096 7419990 ns 7419343 ns 95 bytes_per_second=0/s
BM_RemoveTokensLong/8192 17590660 ns 17588190 ns 39 bytes_per_second=0/s
[2020-01-02 18:33:52.885][105242][critical][assert] [bazel-out/k8-fastbuild/bin/source/common/common/_virtual_includes/utility_lib/common/common/utility.h:465] assert failure: left < right.

Call Stack:
Caught Aborted, suspect faulting address 0x14e3800019fcf
Backtrace (use tools/stack_decode.py to get line numbers):
Envoy version: 132656308f472fa65709cdce9f409ca3b7ff035b/1.13.0-dev/Modified/DEBUG/BoringSSL
#0: Envoy::SignalAction::sigHandler() [0x32a62c]
#1: __restore_rt [0x7f2c1a0ea3a0]
#2: Envoy::BM_IntervalSetInsert17() [0x2c9492]
#3: benchmark::internal::FunctionBenchmark::Run() [0x3bfc61]
#4: benchmark::internal::BenchmarkInstance::Run() [0x3d3cdf]
#5: benchmark::internal::(anonymous namespace)::RunInThread() [0x3cc091]
#6: benchmark::internal::(anonymous namespace)::BenchmarkRunner::DoNIterations() [0x3cb8fc]
#7: benchmark::internal::(anonymous namespace)::BenchmarkRunner::DoOneRepetition() [0x3cb1eb]
#8: benchmark::internal::(anonymous namespace)::BenchmarkRunner::BenchmarkRunner() [0x3cafaa]
#9: benchmark::internal::RunBenchmark() [0x3cac76]
#10: benchmark::internal::(anonymous namespace)::RunBenchmarks() [0x3b5f28]
#11: benchmark::RunSpecifiedBenchmarks() [0x3b5879]
#12: benchmark::RunSpecifiedBenchmarks() [0x3b52d3]
#13: main [0x329bf6]
#14: __libc_start_main [0x7f2c19d3c52b]

[stale]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.